Add package property to FixtureRequest#12853
Closed
apvd wants to merge 3 commits intopytest-dev:mainfrom
Closed
Conversation
nicoddemus
requested changes
Oct 5, 2024
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
This is a great start!
Requests:
- Add a new
featurechangelog entry? - Add yourself to
AUTHORS(optional) - Add an specific test for this feature: a request accessing the new property explicitly, ensuring it is the object we expect.
webknjaz
changed the title
package property to FeatureRequestpackage property to FixtureRequest
Member
|
@apvd I've fixed a typo in the PR title. Please note that you have a list of requested changes from another maintainer above. |
Member
|
I'll close the PR as stale, feel free to re-submit if you get back to it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packageproperty toFeatureRequestclasspackageproperty torequest#12852